chore: export search funcs #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exports several GitHub search and resource functions to the public interface by renaming them from unexported (lowercase) to exported (PascalCase) versions. The changes update function names and comments throughout the code as well as the corresponding test references to ensure consistency.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/server.go | Renamed resource and tool functions to exported variants. |
| pkg/github/search_test.go | Updated test references for renamed search functions. |
| pkg/github/search.go | Exported search functions by renaming them. |
| pkg/github/repository_resource_test.go | Updated tests with exported resource handler functions. |
| pkg/github/repository_resource.go | Renamed resource functions and their comments to be exported. |
| pkg/github/repositories_test.go | Updated test references for repository functions. |
| pkg/github/repositories.go | Exported repository functions by renaming them. |
| pkg/github/pullrequests_test.go | Updated test references for pull request functions. |
| pkg/github/pullrequests.go | Renamed pull request functions to the exported naming convention. |
| pkg/github/issues_test.go | Updated test references for issue functions. |
| pkg/github/issues.go | Exported issue functions with updated naming and comments. |
| pkg/github/code_scanning_test.go | Updated test references for code scanning functions. |
| pkg/github/code_scanning.go | Renamed code scanning functions to be exported. |
SamMorrowDrums
force-pushed
the
export-repositories
branch
from
7ec5938 to
f2bbc19
Compare
DaleSeo
pushed a commit
to DaleSeo/github-mcp-server
that referenced
this pull request
Oct 24, 2025
The secret provided via argument (`-e` flag) [1] was losing the value before listing the tools. This caused failures to connect to the MCP server. The strategy now is to replace the secret value only when encoding the object to generate the template. There was also a missing `--load` flag when executing `docker buildx build` to correctly load the image into the memory. [1] https://github.com/rafaeljusto/mcp-registry/blob/17fdb6eb0a4b47d4ac1a33535554a6fa7e2b2dd3/cmd/create/main.go#L177-L181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export search funcs to public interface.